JuliaLang / julia / #37779

77%

Build Type

push

local

Committed by web-flow

Commit Message

Compile-time stride checks in matmul functions (#54461)

Following on from https://github.com/JuliaLang/julia/pull/54449, this
skips the `stride(A, 2) >= size(A, 1)` check for certain `StridedArray`
types for which the result is always known to be true. The main
difference between this and #54449 is that this omits `StepRange`s as
indices of views, as negative strides aren't allowed in this condition
anymore.

Latency improvements:
```julia
julia> A = rand(2,2); B = rand(size(A)...); C = zeros(size(A));

julia> @time mul!(C, A, B);
  1.300802 seconds (4.55 M allocations: 235.561 MiB, 17.27% gc time, 100.00% compilation time) # nightly v"1.12.0-DEV.528"
  0.893946 seconds (2.54 M allocations: 130.323 MiB, 3.85% gc time, 100.00% compilation time) # This PR
```

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

18 existing lines in 4 files now uncovered.

76529 of 87528 relevant lines covered (87.43%)

16122880.92 hits per line