excaliburjs / Excalibur / 9032193785

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: [#3055] Cirular dependency on Actor (#3056)

This PR resolves a circular dependency issue in Excalibur.js when using TypeScript source files directly. It refactors `ParticleEmitter` by isolating it into a separate file and adjusting the dependency management in `Particles.ts`.

This PR has the advantage that you should not encounter this problem if Webpack should ever be replaced.

Closes  #3055

## Changes
* Isolated `ParticleEmitter`: Moved `ParticleEmitter` to its own file to manage dependencies more effectively.
* Updated `Particles.ts`: Replaced direct dependency with a type import of `ParticleEmitter`.
* Instance Check Adjustment: Replaced the `instanceof` check with a `constructor` presence check.

Run Details

5465 of 6909 branches covered (79.1%)

101 of 112 new or added lines in 3 files covered. (90.18%)

1 existing line in 1 file now uncovered.

12078 of 13224 relevant lines covered (91.33%)

24771.21 hits per line