• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

excaliburjs / Excalibur / 9032193789
89%

Build:
DEFAULT BRANCH: main
Ran 10 May 2024 12:30PM UTC
Jobs 1
Files 214
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 May 2024 12:26PM UTC coverage: 91.304% (+0.002%) from 91.302%
9032193789

push

github

web-flow
fix: [#3055] Cirular dependency on Actor (#3056)

This PR resolves a circular dependency issue in Excalibur.js when using TypeScript source files directly. It refactors `ParticleEmitter` by isolating it into a separate file and adjusting the dependency management in `Particles.ts`.

This PR has the advantage that you should not encounter this problem if Webpack should ever be replaced.

Closes  #3055

## Changes
* Isolated `ParticleEmitter`: Moved `ParticleEmitter` to its own file to manage dependencies more effectively.
* Updated `Particles.ts`: Replaced direct dependency with a type import of `ParticleEmitter`.
* Instance Check Adjustment: Replaced the `instanceof` check with a `constructor` presence check.

5463 of 6909 branches covered (79.07%)

101 of 112 new or added lines in 3 files covered. (90.18%)

12074 of 13224 relevant lines covered (91.3%)

24771.67 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9032193789.1 10 May 2024 12:30PM UTC 0
91.3
GitHub Action Run
Source Files on build 9032193789
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #9032193789
  • 8d43c1d6 on github
  • Prev Build on main (#9010901979)
  • Next Build on main (#9032420721)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc