grpc / grpc-java / #19220
88%
master: 89%

LAST BUILD BRANCH: v1.77.x
DEFAULT BRANCH: master
Ran
Jobs 1
Files 573
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.381% (+0.02%) from 88.358%
#19220

push

github

ejona86 
opentelemetry: Add optional grpc.lb.locality to per-call metrics

The optional label API was added in 4c78a974 and xds_cluster_impl was
plumbed in 077dcbf9.

From gRFC A78:

> ### Optional xDS Locality Label
>
> When xDS is used, it is desirable for some metrics to include an optional
> label indicating which xDS locality the metrics are associated with.
> We want to provide this optional label for the metrics in both the
> existing per-call metrics defined in [A66] and in the new metrics for
> the WRR LB policy, described below.
>
> If locality information is available, the value of this label will be of
> the form `{region="${REGION}", zone="${ZONE}", sub_zone="${SUB_ZONE}"}`,
> where `${REGION}`, `${ZONE}`, and `${SUB_ZONE}` are replaced with the
> actual values.  If no locality information is available, the label will
> be set to the empty string.
>
> #### Per-Call Metrics
>
> To support the locality label in the per-call metrics, we will provide
> a mechanism for LB picker to add optional labels to the call attempt
> tracer.  We will then use this mechanism in the `xds_cluster_impl`
> policy's picker to set the locality label. ...
>
> This label will be available on the following per-call metrics:
> - `grpc.client.attempt.duration`
> - `grpc.client.attempt.sent_total_compressed_message_size`
> - `grpc.client.attempt.rcvd_total_compressed_message_size`

31574 of 35725 relevant lines covered (88.38%)

0.88 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
92.09
 -0.21% ../netty/src/main/java/io/grpc/netty/NettyServerHandler.java
1
96.03
 -0.66% ../core/src/main/java/io/grpc/internal/DelayedClientTransport.java
1
91.76
 -0.59% ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
2
81.05
 0.0% ../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
Jobs
ID Job ID Ran Files Coverage
1 #19220.1 573
88.38
Source Files on build #19220