#19211
88%
master: 89%

Ran 08 May 2024 10:58PM UTC

Jobs 1

Files 571

Run time 1min

Badge

Embed ▾

Committed 08 May 2024 10:50PM UTC coverage: 88.309% (-0.02%) from 88.328%

Build # #19211

Build Type

push

github

Committed by

ejona86

Commit Message

xds: Plumb locality in xds_cluster_impl and weighted_target

As part of gRFC A78:

> To support the locality label in the WRR metrics, we will extend the
> `weighted_target` LB policy (see A28) to define a resolver attribute
> that indicates the name of its child. This attribute will be passed
> down to each of its children with the appropriate value, so that any
> LB policy that sits underneath the `weighted_target` policy will be
> able to use it.

xds_cluster_impl is involved because it uses the child names in the
AddressFilter, which must match the names used by weighted_target.
Instead of using Locality.toString() in multiple policies and assuming
the policies agree, we now have xds_cluster_impl decide the locality's
name and pass it down explicitly. This allows us to change the name
format to match gRFC A78:

> If locality information is available, the value of this label will be
> of the form `{region="${REGION}", zone="${ZONE}",
> sub_zone="${SUB_ZONE}"}`, where `${REGION}`, `${ZONE}`, and
> `${SUB_ZONE}` are replaced with the actual values. If no locality
> information is available, the label will be set to the empty string.

Run Details

31515 of 35687 relevant lines covered (88.31%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.26	-0.16%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2	91.43	-5.71%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
3	95.83	0.0%	../api/src/main/java/io/grpc/MetricInstrumentRegistry.java
4	96.26	0.18%	../xds/src/main/java/io/grpc/xds/WeightedTargetLoadBalancer.java
4	88.52	0.0%	../xds/src/main/java/io/grpc/xds/WrrLocalityLoadBalancer.java
6	78.13	-6.25%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
9	95.63	0.05%	../xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java
10	93.75	-0.24%	../xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java
27	78.74	-1.1%	../core/src/main/java/io/grpc/internal/ServerImplBuilder.java
28	89.47	-0.49%	../core/src/main/java/io/grpc/internal/ManagedChannelImplBuilder.java
57	93.46	0.02%	../core/src/main/java/io/grpc/internal/ManagedChannelImpl.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19211.1	08 May 2024 10:58PM UTC	571	88.31

grpc / grpc-java / #19211
88%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19211

grpc / grpc-java / #19211 88% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19211

grpc / grpc-java / #19211
88%
master: 89%

README BADGES
x