Unleash / unleash / 8997965770

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

chore: add automatic ID generation algorithm (#7001)

This PR adds a function to automatically generate a project ID on
creation. Using this when the id is missing will be handled in following
PRs.

The function uses the existing `slug` package to create a slug, and then
takes the 12 characters of a uuidv4 string to generate an ID.

The included tests check that the 12 character hash is added and that
the resulting string is url friendly (by checking that
`encodeURIComponent` doesn't change it).

We could also test a lot of edge cases (such as dealing with double
spaces, trimming the string, etc), but I think that's better handled by
the library itself (but you can check out what I removed in
https://github.com/Unleash/unleash/pull/7001/commits/2d9bcb639
for an idea).

The function doesn't really need to be in the service; it could be moved to a util. But for proximity, I'll create it here first.

Coverage Stats

2606 of 3394 branches covered (76.78%)

6 of 6 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

13050 of 14874 relevant lines covered (87.74%)

675.99 hits per line