nats-io / nats-server / 8996373117
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 55
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.182% (-0.07%) from 85.252%
8996373117

push

github

web-flow 
[FIXED] Data races websocket/shutdown, DisconnectClientByID and LDMClientByID (#5398)

Saw a data race in Travis during a websocket test during shutdown:
```
==================
WARNING: DATA RACE
Write at 0x00c004430618 by goroutine 112330:
  github.com/nats-io/nats-server/v2/server.(*Server).Shutdown()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/server.go:2527 +0x87e
  github.com/nats-io/nats-server/v2/server.TestWSTLSConnection.deferwrap1()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/websocket_test.go:2223 +0x33
  runtime.deferreturn()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/runtime/panic.go:602 +0x5d
  testing.tRunner()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/testing/testing.go:1742 +0x44
Previous read at 0x00c004430618 by goroutine 112339:
  github.com/nats-io/nats-server/v2/server.(*client).generateClientInfoJSON()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:2389 +0x406
  github.com/nats-io/nats-server/v2/server.(*Server).createWSClient()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/websocket.go:1280 +0xb24
  github.com/nats-io/nats-server/v2/server.(*Server).startWebsocketServer.func1()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/websocket.go:1184 +0x1db
  net/http.HandlerFunc.ServeHTTP()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/net/http/server.go:2166 +0x47
  net/http.(*ServeMux).ServeHTTP()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/net/http/server.go:2683 +0x1ef
  net/http.serverHandler.ServeHTTP()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/net/http/server.go:3137 +0x2a1
  net/http.(*conn).serve()
      /home/travis/.gimme/versions/go1.22.2.linux.amd64/src/net/http/server.go:203... (continued)

65290 of 76648 relevant lines covered (85.18%)

733620.54 hits per line

Jobs
ID Job ID Ran Files Coverage
1 8996373117.1 0
85.18
 GitHub Action Run
Source Files on build 8996373117
Detailed source file information is not available for this build.