8948056000
83%

Ran 04 May 2024 05:27AM UTC

Jobs 1

Files 55

Run time 1min

Badge

Embed ▾

Committed 03 May 2024 09:22PM UTC coverage: 85.258% (-0.01%) from 85.27%

Build # 8948056000

Build Type

push

github

Committed by

web-flow

Commit Message

Fix cleanup of messages that lost interest after consumer FilterSubject update (#5385)

When deleting a consumer, messages that lost interest would be deleted
from the stream.
The same would not happen for messages that lost interest due to a
consumer `FilterSubject` update.

This PR fixes that by extracting the cleanup logic that happened on
delete and reuse it on update.

The tests are trimmed down versions of the unit test described here:
https://github.com/nats-io/nats-server/issues/4878#issuecomment-2025831232.
These are duplicates of each other, apart from the `Replicas: 3` for the
clustered setup (and of course in `jetstream_test.go` vs
`jetstream_cluster_4_test.go`). Please let me know if and how those
should be deduped if you'd prefer them to be. :slightly_smiling_face:

Resolves https://github.com/nats-io/nats-server/issues/4878

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

65364 of 76666 relevant lines covered (85.26%)

761684.57 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	8948056000.1	04 May 2024 05:27AM UTC	0	85.26	GitHub Action Run

Source Files on build 8948056000

Detailed source file information is not available for this build.

nats-io / nats-server / 8948056000
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8948056000

nats-io / nats-server / 8948056000 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8948056000

nats-io / nats-server / 8948056000
83%

README BADGES
x