Unleash / unleash / 8878000196

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

chore: remove workaround (#6942)

This PR removes the workaround introduced in
https://github.com/Unleash/unleash/pull/6931. After
https://github.com/ivarconr/unleash-enterprise/pull/1268 has been
merged, this should be safe to apply.

Notably, this PR: 
- tightens up the type for the enable change request function, so we can
use that to inform the code
- skips trying to do anything with an empty array

The last point is less important than it might seem because both the env
validation and the current implementation of the callback is essentially
a no-op when there are no envs. However, that's hard to enforce. If we
just exit out early, then at least we know nothing happens.

Optionally, we could do something like this instead, but I'm not sure
it's better or worse. Happy to take input.
```ts
            const crEnvs = newProject.changeRequestEnvironments ?? []
            await this.validateEnvironmentsExist(crEnvs.map((env) => env.name));
            const changeRequestEnvironments =
                await enableChangeRequestsForSpecifiedEnvironments(crEnvs,);

            data.changeRequestEnvironments = changeRequestEnvironments;
```

Coverage Stats

2600 of 3393 branches covered (76.63%)

6 of 7 new or added lines in 1 file covered. (85.71%)

1 existing line in 1 file now uncovered.

13033 of 14867 relevant lines covered (87.66%)

676.92 hits per line