f-dangel / curvlinops / 8818810086

89%

Build Type

push

github

Committed by web-flow

Commit Message

[ADD] Support arbitrary `X` in `data` (e.g. HuggingFace models) (#100)

* [ADD] Generalize assumption about X

* Update typehint

* [REF] Add example how to use the UserDict input for HuggingFace models

* Add tests for `UserDict` and `dict` `X`s

* Add Huggingface `transformers` and `datasets` to the docs deps

* Address comments in `_base.py`

* Resolves comments in `fisher.py` and `kfac.py`

* Update docstrings and example in documentation

* Update `functorch.py` to accomodate dict-like inputs

* Make `*JacobianLinearOperator` aware of dict-like inputs

* Update tests

* Remove unused test case

* Add `to(device)` in `ModelWithDictInput` test model

* Run

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.13.2

Nothing to do: no files or paths have have been passed in!

Try one of the following:

    `isort .` - sort all Python files, starting from the current directory, recursively.
    `isort . --interactive` - Do the same, but ask before making any changes.
    `isort . --check --diff` - Check to see if imports are correctly sorted within this project.
    `isort --help` - In-depth information about isort's available command-line options.

Visit https://pycqa.github.io/isort/ for complete information about how to use isort.

* Fix import error in unit test

* Address @f-dangel's comments

* Better explanation in ignoring KFAC reduce & expand cases

* Merge with main

* Fix `y` device in `_base.py`

* Resolves flake8 warnings

Run Details

71 of 82 new or added lines in 8 files covered. (86.59%)

2 existing lines in 2 files now uncovered.

1219 of 1376 relevant lines covered (88.59%)

0.89 hits per line