Ouranosinc / xclim / 8743914296

92%

Build Type

push

github

Committed by web-flow

Commit Message

Remove columns that are all NaNs in make_criteria (#1713)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Methods such as kmeans clustering will crash if there are NaNs in the
data. This is something that should happen if only a subset of
realizations are NaNs, but we should be safe to remove the columns that
are NaN across all realizations.

### Does this PR introduce a breaking change?

* No


### Other information:

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

8724 of 9612 relevant lines covered (90.76%)

5.87 hits per line