Ouranosinc / xclim / 8561687170
92%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8561687170

push

github

web-flow 
Fix time_bnds for xarray 2024.03 (#1700)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1675
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [ ] CHANGES.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Fix `time_bnds`. While trying to adapt the code to xarray >= 2024.03,
I realized that it wasn't giving the good output! If the resampling
frequency was a multiple of the original frequency, it did work, but not
otherwise.
* In the tests, remove all calls to the private api.

I don't know how to remove all private API calls from `time_bnds`. The
easiest option is to call a resampling function on the `Resample` object
but that beats the purpose of accepting these objects in the first
place. The point was to construct the bounds without executing the
resampling itself. However, I'm not sure this feature is actually
useful... The current proposition uses code that is common to 2023.10
and 2024.03, at least that's better than before.

### Does this PR introduce a breaking change?
No.

### Other information:
Source Files on build 8561687170
Detailed source file information is not available for this build.