rust-bitcoin / rust-bitcoin / 8529894026

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2514: Add hex parsing to `pow` types

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f019e24f1f4c58f85177d5d77647dcbf23941b02">f019e24f1<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/69716f17b96dfd9475d044beccb18f8d218eae7a"> Add hex parsing to pow types (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d33625f6e2d4986c4e8116016a8b4530d374f2c9">d33625f6e</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/69716f17b96dfd9475d044beccb18f8d218eae7a"> units: Introduce public hex_u128 function (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9705d51782264e8ff5876a5571df3cb469a84991">9705d5178</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/69716f17b96dfd9475d044beccb18f8d218eae7a"> docs: Use backticks on stdlib type (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/cf65bf035f81e4a37f21752cc0640387b291b908">cf65bf035</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/69716f17b96dfd9475d044beccb18f8d218eae7a"> Introduce local variable (Tobin C. Harding)
126972277 Move helper function (Tobin C. Harding)
dca054c68 test: Add unit tests for hex_u32 (Tobin C. Harding)

Pull request description:

  The `pow` types implement `fmt::LowerHex` but do not implement hex parsing.

  Add inherent methods `from_hex` and `from_prefixed_hex` to the  `pow` types - as we did for locktime types.

ACKs for top commit:
  apoelstra:
    ACK f019e24f1f4c58f85177d5d77647dcbf23941b02
  sanket1729:
    ACK f019e24f1f4c58f85177d5d77647dcbf23941b02

Tree-SHA512: d682e1259cce90de4d209648a57f596dfd2

72 of 88 new or added lines in 2 files covered. (81.82%)

19165 of 23055 relevant lines covered (83.13%)

16866.83 hits per line