rust-bitcoin / rust-bitcoin / 8523508788

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2337: Add check to max difficulty transition threshold

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/fd6fedc3ad07de9fc8e13eb8dd9beaa8e6dc8785">fd6fedc3a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/499f36f97264d62d59ac5177536ca643cf983bf2"> Improve API for max target threshold calculation (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6e47d57744a4ddc76b13b12586ded228525b4707">6e47d5774</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/499f36f97264d62d59ac5177536ca643cf983bf2"> Rename difficulty transition threshold functions (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4121c9a09fba775ae89d1e44082596dd229a6e9d">4121c9a09</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/499f36f97264d62d59ac5177536ca643cf983bf2"> Rename Params::pow_limit to max_attainable_target (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f0f6d3f1627cd3ebb0ae12bfc92690b102168824">f0f6d3f16</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/499f36f97264d62d59ac5177536ca643cf983bf2"> Take Params instead of Network in difficulty function (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/104dee9376ea7abdc16b39eab74317af19a359e9">104dee937</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/499f36f97264d62d59ac5177536ca643cf983bf2"> Debug assert that target != zero in difficulty calc (Tobin C. Harding)
c1ba496a0 Document current behaviour of difficulty_float (Tobin C. Harding)
3d0114637 Allow needless-borrows-for-generic-args (Tobin C. Harding)
2a6821b42 Use link to CompactTarget in rustdoc (Tobin C. Harding)

Pull request description:

  When computing the maximum difficulty transition threshold we forgot to check that the returned `Target` is not bigger than the maximum. This value is network specific so keep the original logic but with `_unchecked` on the function name.

  This was noted in the discussion on #2161

ACKs for top commit:
  apoelstra:
    ACK fd6fedc3ad07de9fc8e13eb8dd9beaa8e6dc8785
  sanket1729:
    ACK fd6fedc3ad07de9fc8e13eb8dd9beaa8e6dc8785

Tree-SHA512: 520ee2a076dc7bcdb569e22b21efb3ae74d

12 of 22 new or added lines in 3 files covered. (54.55%)

19101 of 22975 relevant lines covered (83.14%)

16888.71 hits per line