• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

openSUSE / agama / 8422178448
74%
master: 72%

Build:
Build:
LAST BUILD BRANCH: storage-volume-keywords
DEFAULT BRANCH: master
Ran 25 Mar 2024 03:01PM UTC
Jobs 3
Files 715
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Mar 2024 02:58PM UTC coverage: 74.854% (+0.02%) from 74.839%
8422178448

push

github

web-flow
New storage settings for different target devices  (#1068)

## Problem

There are three main different scenarios to be supported by the storage
proposal:

* a) Install in a target disk device (e.g., disk, RAID, DASD, etc).
* b) Install in a new LVM volume group.
* c) Reuse an existing LVM volume group.

Moreover, the proposal should be able to indicate the following boot
options:

* a) Whether to configure or not separate partitions for booting.
* b) What device to use for creating the booting partitions.

## Solution

Adapt the storage settings to support all the scenarios described above:

~~~
Target                 s (options: "disk", "newLvmVg", "reusedLvmVg")
TargeDevice s (optional: does not make sense if Target is "newLvmVg")
TargetPVDevices as (optional: only makes sense if Target is "newLvmVg")
ConfigureBoot          b
BootDevice             s
~~~

## Testing

* Added and adapted unit tests
* Tested manually

1641 of 2435 branches covered (67.39%)

Branch coverage included in aggregate %.

196 of 196 new or added lines in 19 files covered. (100.0%)

68 existing lines in 4 files now uncovered.

17592 of 23259 relevant lines covered (75.64%)

25.18 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
97.44
0.0% service/lib/agama/storage/proposal_settings_reader.rb
2
95.45
0.0% service/lib/agama/storage/volume_conversion/from_y2storage.rb
26
80.59
0.0% service/lib/agama/dbus/storage/manager.rb
39
88.86
0.27% web/web/src/client/storage.js
Subprojects
ID Flag name Job ID Ran Files Coverage
1 web 8422178448.1 25 Mar 2024 03:01PM UTC 309
74.73
GitHub Action Run
1 rust 8187148015.1 07 Mar 2024 11:16AM UTC 80
42.49
GitHub Action Run
1 service 8392224502.1 22 Mar 2024 02:58PM UTC 326
85.52
GitHub Action Run
Source Files on build 8422178448
  • Tree
  • List 715
  • Changed 51
  • Source Changed 3
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #8422178448
  • 7e1476c9 on github
  • Prev Build on storage-next-device-selection (#8392224502)
  • Next Build on storage-next-device-selection (#8541085658)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc