openSUSE / agama / 8392224502

74%

master: 72%

Build Type

push

github

Committed by web-flow

Commit Message

[Service] Make it possible to use non-auto sizes for volumes with adjust_by_ram (#1111)

## Problem

In Agama a volume can have automatic sizes based on one or several of
the following reasons:

- Snapshots
- Fallbacks from other volumes (eg. "/" max size can exist or not based
on the existence of "/home")
- Size of the RAM

But the third one was not working because it was impossible to set the
sizes manually for volumes with the property `adjust_by_ram` in their
corresponding outline.

## Solution

This sets the new YaST setting `ignore_adjust_by_ram` if the user has
decided to manually enforce sizes. So now it's possible to honor the
automatic size or to use custom sizes instead.

Using the automatic size

| The table | The form |
|-|-|
|
![table-auto](https://github.com/openSUSE/agama/assets/3638289/4f7d2b6f-b728-4d47-aca4-8321301e822a)
|
![form-auto](https://github.com/openSUSE/agama/assets/3638289/eb072fd2-011f-4eb8-8c02-1a218053254b)
|

Forcing manual sizes

| The table | The form |
|-|-|
|
![table-man](https://github.com/openSUSE/agama/assets/3638289/a25510fa-b4fd-40f4-bc4c-c096995a6c57)
|
![form-man](https://github.com/openSUSE/agama/assets/3638289/59994396-3627-4dac-b18b-5aa63ce0dbcc)
|



To get some background on how this functionality compares to the
traditional YaST checkbox "Enlarge to RAM Size for Suspend", see the
dedicated section at the description of
https://github.com/openSUSE/agama/pull/1081.

Additionally, this pull request enables `adjust_by_ram` for swap at the
Tumbleweed product, to raise awareness and get feedback.

## Testing

- Added a new unit test
- Tested manually (see screenshots above)

## Dependencies

Needs https://github.com/yast/yast-storage-ng/pull/1376 at
yast2-storage-ng, which implies the corresponding rpm dependency has
been updated.

Run Details

1639 of 2432 branches covered (67.39%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

17576 of 23243 relevant lines covered (75.62%)

25.23 hits per line