babelfish-for-postgresql / babelfish_extensions / 8374875091

74%

BABEL_5_X_DEV: 77%

push

github

Fix issues with datatypes for Logical Replication (#2268) (#2428)

This commit fixes following issues:

1. (Var)binary columns are not replicated correctly since input function considers
the value as a raw ASCII string although the value is actually already in binary format.
Fixed this by using IsLogicalWorker() with existing TSQLHexConstTypmod
check in varbinaryin function to correctly take binary input sent by the publisher.
2. SQL_VARIANT columns are replicated correctly as far as the data contents are
concerned, but the meta data is lost in the process which is because sql_variant output
function returns the value in the respective datatype in string format which when fed
back to the sql_variant input function gets treated as a varchar value.
Fixed this by replicating sql_variant values as bytea. We will use MyReplicationSlot
and MyWalSnd in sqlvariantout function on publisher and IsLogicalWorker() in
sqlvariantin function on subscriber to identify if we are in logical replication context.
3. On the subscriber side, IsLogicalWorker() is sufficient for native PG applyworker
but will not work with external providers like pglogical, so will rely on SessionReplicationRole
being replica since most of the providers seem to set this GUC.

Additionally, this adds support to run logical replication tests in github action along with
JDBC framework.

Task: BABEL-3427, BABEL-4049
Signed-off-by: Rishabh Tanwar ritanwar@amazon.com

Signed-off-by: Rishabh Tanwar ritanwar@amazon.com

6 of 6 new or added lines in 2 files covered. (100.0%)

41163 of 56437 relevant lines covered (72.94%)

62882.29 hits per line