babelfish-for-postgresql / babelfish_extensions / 8370436153

74%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Support grant/revoke on schema feature (#2415)

Supported GRANT/REVOKE .. ON SCHEMA .. in Babelfish
Supported syntax GRANT ON SCHEMA::<schema_name> TO <user_name>
Supported syntax REVOKE ON SCHEMA::<schema_name> TO/FROM <user_name>

We have introduced a catalog sys.babelfish_schema_permission to hold the information about objects and its permissions.

GRANT on schema/objects add/update a row in the catalog table if does not exist already.
REVOKE on schema/objects removes/update the corresponding row in the catalog table if it exists already.
Drop statement for OBJECT/SCHEMA removes all the relevant object entries from the catalog.

sp_rename updates the object name in sys.babelfish_schema_permission catalog so that the permission is tracked correctly in the catalogs

Added metadata check for schema permissions catalog

GRANT/REVOKE ... ON ... SCHEMA ... WITH GRANT OPTION/CASCADE does not work as expected -> Throw unsupported error
CREATE SCHEMA ... GRANT ... ON ... SCHEMA throws syntax error -> Throw unsupported error
REVOKE GRANT OPTION FOR ... ON SCHEMA should be unsupported in Babelfish

Specific to Upgrade: The catalogs will not track the permissions granted on the OBJECTs on the earlier versions.

Issues Resolved
Task: BABEL-4344, BABEL-4775, BABEL-4485, BABEL-4739, BABEL-4738, BABEL-4758

Signed-off-by: Shalini Lohia lshalini@amazon.com

Run Details

723 of 760 new or added lines in 10 files covered. (95.13%)

2 existing lines in 2 files now uncovered.

41151 of 56432 relevant lines covered (72.92%)

62066.24 hits per line