rust-bitcoin / rust-bitcoin / 8359769717

82%

push

github

Merge rust-bitcoin/rust-bitcoin#2582: fix: Manually implement serde traits

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/911f8cbd6a73199754becf17993a718f953d7f22">911f8cbd6 fix: Manually implement serde traits (Tobin C. Harding)

Pull request description:

  Currently we are deriving the serde traits for the `absolute::{Height, Time}` types, this is incorrect because we maintain an invariant on the inner `u32` of both types that it is above or below the threshold.

  Manually implement the serde traits and pass the deserialized `u32` to `from_consensus` to maintain the invariant.

  Close: #2559

ACKs for top commit:
  apoelstra:
    ACK 911f8cbd6a73199754becf17993a718f953d7f22
  sanket1729:
    ACK 911f8cbd6a73199754becf17993a718f953d7f22.

Tree-SHA512: 28f9f3e23e1dd30fa3f09eec8d80fbbd19d

37 of 37 new or added lines in 1 file covered. (100.0%)

19806 of 23616 relevant lines covered (83.87%)

16408.19 hits per line