rust-bitcoin / rust-bitcoin / 8346102551

82%

push

github

Merge rust-bitcoin/rust-bitcoin#2577: Fix cargo cult programming

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/290e4418e68f4978b44e46f174f0a0243122278b">290e4418e units: Fix cargo cult programming (Tobin C. Harding)

Pull request description:

  When creating the ParseIntError in `hex_u32` I (tobin) just cargo cult programmed the generic stuff without thinking.

  - The `is_signed` field is used to denote whether we were attempting to parse a signed or unsigned integer, it should be `false`.
  - The `bits` field should be directly set to 32.

ACKs for top commit:
  apoelstra:
    ACK 290e4418e68f4978b44e46f174f0a0243122278b
  sanket1729:
    ACK 290e4418e68f4978b44e46f174f0a0243122278b

Tree-SHA512: 7dfd9f0cd24528ef741b953860dca3c5068

2 of 2 new or added lines in 1 file covered. (100.0%)

19769 of 23581 relevant lines covered (83.83%)

16421.91 hits per line