Instagram
/
IGListKit
/
8322841528
96%
master: 100%
master: 100%
|
Ran
|
Jobs
1
|
Files
49
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 99.585%. Remained the same
push
github
facebook-github-botRemove legacy build pipeline from GitHub Actions Summary: After landing the diff to add a privacy manifest to IGListKit's SPM package, the `Carthage-Legacy-Lipo-Binaries` build pipeline started failing. Looking into it, this is because in order to support bundled resources in a Swift Package (Which is necessary to staple the manifest to the framework), the build tools version must be set at Swift 5.3. Meanwhile, the legacy build pipeline requires Xcode 11 in order to support the `lipo` command, and that one only goes up to Swift build tools 5.2. The reason why XCFramework superseded fat binaries is because fat binaries may only have 1 slice of any given architecture in it (eg arm64). And with Apple Silicon, 2 arm64 slices (One for the iOS Simulator, and one for iOS hardware) are basically the norm now. With that in mind, now that the Apple Silicon transition is complete, and in order to properly support privacy manifests, I think it's time we retire the `lipo` build pipeline in favour of supporting just the XCFramework route. Reviewed By: benhgreen Differential Revision: D55005596 fbshipit-source-id: ad9bc9512
4077 of 4094 relevant lines covered (99.58%)
746.52 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | iOS - 8322841528.1 | 0 |
99.56 |
GitHub Action Run |
Source Files on build 8322841528
Detailed source file information is not available for this build.