djeedai / bevy_hanabi / 8308913095

66%

Build Type

push

github

Committed by web-flow

Commit Message

Move properties into `Module` (#301)

Move the declaration of properties from `EffectAsset` into `Module`.
Properties are only used in the context of expressions owned by a
`Module`, so it makes more sense for them to be owned by the `Module`
itself. This also forces them to be declared upfront with a type, which
enables adding type checking during expression building (not in this
change) instead of generating invalid shader code and only observing
issue when actually spawning an effect.

Run Details

45 of 59 new or added lines in 4 files covered. (76.27%)

1 existing line in 1 file now uncovered.

3038 of 5769 relevant lines covered (52.66%)

22.55 hits per line