Ouranosinc / xscen / 8300211562

90%

push

github

Tests for spatial.py, remove old 'region' (#367)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Tests for the functions in `xs.spatial`
* Small bugfix in `creep_weights` for an edge case where the grid is
very small, `n` is high, and `mode=wrap`.
* Refactored `subset` to separate into multiple smaller functions.

### Does this PR introduce a breaking change?

* For 2D grids, the grid resolution estimation will now take the maximum
difference, instead of the difference of the first indexes. The impact
should be minimal.
* Remove old (deprecated) instances of `region`
* Remove the deprecated `xs.extract.clisops_subset()`

70 of 70 new or added lines in 1 file covered. (100.0%)

2944 of 4019 relevant lines covered (73.25%)

5.75 hits per line