Ouranosinc / xscen / 8299132047

87%

push

github

Add biasadjust tests (#366)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* add bias adjust tests
* fixed a few bugs:
* Removed train from the inside the period for loop. Only need to do it
once and bugged with group if inside loop.
* fix `_add_preprocessing_attr` that was not actually modifying the
attrs
  * Change way of defining default group

### Does this PR introduce a breaking change?
* `adjust` won't fail if dict group and many periods.
* `preprocessing_attrs` will actually be added
* If pass `group=False`, it will actually be False.

### Other information:

1. Is it ok to remove the TODOs ? I'm not sure exactly what they were
referring to, I don't think they are relevant anymore.
2. Should we remove `moving_yearly_window` I am not actually using the
args for info-crue cmip6 and the function has changed name in xclim.

11 of 11 new or added lines in 1 file covered. (100.0%)

2858 of 4007 relevant lines covered (71.33%)

5.59 hits per line