#19095
88%
master: 89%

Ran 11 Mar 2024 08:51PM UTC

Jobs 1

Files 553

Run time 2min

Badge

Embed ▾

Committed 11 Mar 2024 08:40PM UTC coverage: 88.305%. Remained the same

Build # #19095

Build Type

push

github

Committed by

ejona86

Commit Message

rls: Fix a local and remote race

The local race passes `rlsPicker` to the channel before
CachingRlsLbClient is finished constructing. `RlsPicker` can use
multiple of the fields not yet initialized. This seems not to be
happening in practice, because it appears like it would break things
very loudly (e.g., NPE).

The remote race seems incredibly hard to hit, because it requires an RPC
to complete before the pending data tracking the RPC is added to a map.
But with if a system is at 100% CPU utilization, maybe it can be hit. If
it is hit, all RPCs needing the impacted cache entry will forever be
buffered.

Run Details

31064 of 35178 relevant lines covered (88.31%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	88.89	-0.41%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
2	83.16	2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3	88.57	-8.57%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
37	81.9	0.04%	../rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19095.1	11 Mar 2024 08:51PM UTC	553	88.31

grpc / grpc-java / #19095
88%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19095

grpc / grpc-java / #19095 88% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19095

grpc / grpc-java / #19095
88%
master: 89%

README BADGES
x