djeedai / bevy_hanabi / 8129319978

66%

push

github

Improve serialization format of `EffectAsset` (#294)

This change makes a few improvements to the serialized representation of
an `EffectAsset`:
- `LiteralExpr`, `ExprHandle`, and `Module` are now
  `#[serde(transparent)]`, which makes them less verbose.
- `VectorValue` is serialized as its glam math type representation,
  making it a lot more readable in text format (_e.g._ RON).

Before:

```
module: (
    expressions: [
        Literal((
            value: Vector((
                vector_type: (
                    elem_type: Float,
                    count: 3,
                ),
                storage: (1067030938, 3227307213, 1118770935, 0),
            )),
        )),
        Literal((
            value: Vector((
                vector_type: (
                    elem_type: Bool,
                    count: 2,
                ),
                storage: (0, 4294967295, 0, 0),
            )),
        )),
        Binary(
            op: Add,
            left: (
                index: 2,
            ),
            right: (
                index: 1,
            ),
        ),
    ],
),
```

After:

```
module: [
    Literal(Vector(Vec3((1.2, -3.45, 87.54485)))),
    Literal(Vector(BVec2((false, true)))),
    Binary(
        op: Add,
        left: 2,
        right: 1,
    ),
]
```

12 of 37 new or added lines in 1 file covered. (32.43%)

2964 of 5321 relevant lines covered (55.7%)

24.19 hits per line