safe-global / safe-client-gateway / 7844930038

89%

push

github

Move authentication params to request headers (#1117)

- Moves authentication related headers from the request body to the request headers.
  * Top-level request body JSON property `signature` was moved to `Safe-Wallet-Signature` header.
  * Top-level request body JSON property `timestamp` was moved to `Safe-Wallet-Signature-Timestamp` header.
- Moves the `signer` body property to the path when appropriate (REST resource path):
  * `PUT /v1/chains/:chainId/safes/:safeAddress/emails/verify-resend` is now `POST /v1/chains/:chainId/safes/:safeAddress/emails/:signer/verify-resend`
    - `POST` because it is mostly triggering a side effect (sending an email).
   * `PUT /v1/chains/:chainId/safes/:safeAddress/emails/verify` is now `PUT /v1/chains/:chainId/safes/:safeAddress/emails/:signer/verify`
   * `DELETE /v1/chains/:chainId/safes/:safeAddress/emails` is now `DELETE /v1/chains/:chainId/safes/:safeAddress/emails/:signer`
   * `PUT /v1/chains/:chainId/safes/:safeAddress/emails` is now `PUT /v1/chains/:chainId/safes/:safeAddress/emails/:signer`

Future work:

We can consider having a single guard for the headers only. However the authentication is message specific and therefore route specific (which has parameters set at runtime).

1516 of 1820 branches covered (0.0%)

Branch coverage included in aggregate %.

5800 of 6041 relevant lines covered (96.01%)

183.22 hits per line