rust-bitcoin / rust-bitcoin / 7820462893

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2335: Improve error handling in errors emmited by `keys`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d3d5ee1047dd6f75560aedf0d971669a05137be3">d3d5ee104 Improve error handling in errors emmited by `keys` (harshit933)

Pull request description:

  For now I have tried to group those functions which can produce more than one error and changed the functions which were  generating single error from `Key::Error` to the respective error. Let me know if this needs to be changed.

  Also in `psbt/error.rs` I have changed the `InvalidPublicKey(crate::crypto::key::Error)` to `InvalidPublicKey(crate::crypto::key::FromSliceError)`. What should be done here?

  Changes -
  - in `from_slice` changed the `error` to `FromSliceError`.
  - in `verify` changed to `secp256k1::Error` as it can return only one error.
  - in `from_str` changed to `FromSliceError`.
  - in `CompressedPublicKey` changed `verify` from `Error` to `secp236k1::Error` as it only returns one error.
  - introduces CompressedPublicKeyError
  - Removes impl from `bip32.rs`

  Potential fix #2291

ACKs for top commit:
  Kixunil:
    ACK d3d5ee1047dd6f75560aedf0d971669a05137be3
  tcharding:
    ACK d3d5ee1047dd6f75560aedf0d971669a05137be3

Tree-SHA512: 21681bbf83207a0c924382e852a0b2523c2

19350 of 23028 relevant lines covered (84.03%)

16815.22 hits per line