rust-bitcoin / rust-bitcoin / 7820379288

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2451: Remove m prefix requirement

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ccbd09d5fbdb7ec26362b6b6719755e000f56e9c">ccbd09d5f Remove unnecessary m/ prefix requirement (josibake)

Pull request description:

  `m` in BIP0032 is a variable, not a constant. Requiring it as a constant here is confusing and can lead to erroneous conclusions if using this library as a means of understanding BIP0032.

  Fixes #2449

ACKs for top commit:
  Kixunil:
    ACK ccbd09d5fbdb7ec26362b6b6719755e000f56e9c
  apoelstra:
    ACK ccbd09d5fbdb7ec26362b6b6719755e000f56e9c

Tree-SHA512: b641679f96180dfd1f2254201b2419c5ec1

19343 of 22985 relevant lines covered (84.15%)

16838.17 hits per line