corridor / sqlalchemy-history / 7457900041

94%

push

github

fix(#121): handle join_txn_mode for version_session

- SQLA 2.0 introduced new session param called `join_transaction_mode`
  which changes the behaviour of how existing transactions are handled

- When using a Connection with an existing SAVEPOINT:
  `SQLA-1.4`: the Session would propagate both commit() and rollback()
  calls to the underlying transaction.
  `SQLA-2.0`: use join_transaction_mode=control_fully to replicate the
  same behaviour.

- When using a Connection without an existing SAVEPOINT:
  `SQLA-1.4`: the Session would propagate only rollback() calls to the
  underlying transaction.
  `SQLA-2.0`: use join_transaction_mode=rollback_only to replicate the
  same behaviour.

- use `rollback_only` mode while creation of version_session, as it is
  using an existing connection, and we are never doing a commit() on it.

1003 of 1111 branches covered (0.0%)

Branch coverage included in aggregate %.

5130 of 5185 relevant lines covered (98.94%)

19.02 hits per line