Ouranosinc / xclim / 7226785507

90%

main: 92%

push

github

Fixing missing=0 in convert calendar (#1563)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes #1562, fixes
https://github.com/Ouranosinc/ESPO-Internal/issues/3
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* When `missing=0` is passed to `convert_calendar`, it is used instead
of replaced by `np.NaN` by faulty expression.

### Does this PR introduce a breaking change?
No.

### Other information:
Xarray's implementation does not have this problem.

1 of 1 new or added line in 1 file covered. (100.0%)

8590 of 9497 relevant lines covered (90.45%)

4.37 hits per line