uber / tchannel-go / 1988

88%

dev: 88%

push

travis-ci

Fix channel close not checking state under write lock

It's possible for multiple connections to close and trigger
connectionCloseStateChange from multiple goroutines.

This could lead to:

G1: C1 closes, and runs connectionCloseStateChange
G1: Finds minState connectionInboundClosed
G1: updateTo = ChannelInboundClosed
<g1 scheduled off before it completes>
G2: C2 closes, and runs connectionCloseStateChange
G2: Finds minState connectionClosed
G2: updateTo = ChannelClosed
G2: Updates channel state to ChannelClosed
<g1 is rescheduled>
G1: Grabs state lock, and sets state to ChannelInboundClosed

Since all connections are closed, the channel will be stuck in
ChannelInboundClosed.

We should be checking that the decision we made is not stale by
comparing the state matches what we had before the lock when making
the change.

13 of 13 new or added lines in 1 file covered. (100.0%)

3799 of 4348 relevant lines covered (87.37%)

10777.34 hits per line