1987
88%
dev: 88%

Ran 02 Jun 2016 10:55PM UTC

Jobs 4

Files 42

Run time 7min

Badge

Embed ▾

pending completion

Build # 1987

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix channel close not checking state under write lock

It's possible for multiple connections to close and trigger
connectionCloseStateChange from multiple goroutines.

This could lead to:

G1: C1 closes, and runs connectionCloseStateChange
G1: Finds minState connectionInboundClosed
G1: updateTo = ChannelInboundClosed
<g1 scheduled off before it completes>
G2: C2 closes, and runs connectionCloseStateChange
G2: Finds minState connectionClosed
G2: updateTo = ChannelClosed
G2: Updates channel state to ChannelClosed
<g1 is rescheduled>
G1: Grabs state lock, and sets state to ChannelInboundClosed

Since all connections are closed, the channel will be stuck in
ChannelInboundClosed.

We should be checking that the decision we made is not stale by
comparing the state matches what we had before the lock when making
the change.

Run Details

3799 of 4348 relevant lines covered (87.37%)

107856.41 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1987.1 (TEST_TIMEOUT_SCALE=20)	02 Jun 2016 11:01PM UTC	42	85.51	Travis Job 1987.1
2	1987.2 (TEST_TIMEOUT_SCALE=20)	02 Jun 2016 11:01PM UTC	42	86.88	Travis Job 1987.2
3	1987.3 (TEST_TIMEOUT_SCALE=20)	02 Jun 2016 11:01PM UTC	42	86.65	Travis Job 1987.3
4	1987.4 (TEST_TIMEOUT_SCALE=20)	02 Jun 2016 11:02PM UTC	42	85.32	Travis Job 1987.4

Source Files on build 1987

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1987
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1987

uber / tchannel-go / 1987 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1987

uber / tchannel-go / 1987
88%
dev: 88%

README BADGES
x