6925626671
83%

Ran 20 Nov 2023 05:16AM UTC

Jobs 1

Files 53

Run time 6s

Badge

Embed ▾

Committed 19 Nov 2023 08:33PM UTC coverage: 85.155% (-0.04%) from 85.191%

Build # 6925626671

Build Type

push

github

Committed by

web-flow

Commit Message

Only drop firstSeq under DiscardOld policy. (#4802)

No matter how a DiscardNew stream has gotten into a state where it is
exceeding its configured limits, it it is never appropriate to fall back
to DiscardOld behavior. Applications rely on message durability after
receiving delivery acknowledgement from a DiscardNew stream.

This patch adds a safety check to filestore's and memstore's limit
reconciliation functions to prevent them from silently discarding a
stream's first messages unless DiscardOld is configured.

Resolves #4775. Silent data loss: enforceMsgLimit() and
enforceBytesLimit() should never modify streams configured with
DiscardPolicy.NEW

Related to #4771, where a nearby bug in message size calculation caused
silent data loss.

Run Details

61953 of 72753 relevant lines covered (85.16%)

177237.18 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	6925626671.1	20 Nov 2023 05:16AM UTC	0	85.16	GitHub Action Run

Source Files on build 6925626671

Detailed source file information is not available for this build.

nats-io / nats-server / 6925626671
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6925626671

nats-io / nats-server / 6925626671 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6925626671

nats-io / nats-server / 6925626671
83%

README BADGES
x