Ouranosinc / xclim / 6776998357
90%
main: 92%

LAST BUILD BRANCH: eco-ci-project
DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6776998357

push

github

web-flow 
Refactor robustness methods (#1514)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Add `ipcc-advanced` as a test to `ensembles.change_significance`. This
corresponds to the simpler alternative of approach C as described in the
Cross-Chapter Box 1 of the [IPCC Atlas (AR6,
WG1)](https://www.cambridge.org/core/books/climate-change-2021-the-physical-science-basis/atlas/24E1C016DBBE4725BDFBC343695DE7DB).
* Add two examples in the "Ensembles" notebook to show how xclim can be
used to get the IPCC-recommended hatching masks.
* Add a very simple `detrend` function.

### Does this PR introduce a breaking change?
No, but it might, see below.

### Other information:
As you can see in the examples, the IPCC decouples the "change
significance" from the "sign agreement", while xclim does not. This make
the second example more complex than expected.

I thought of :
- Changing the output of `change_significance` so that `pos_frac` is
independent of change significance
- Adding a third output so we have: `significant_change_frac,
significant_positive_change_frac, positive_change_frac`.
- Adding a keyword argument to switch between the two modes.
First two are breaking changes while the thirds feels overly heavy for
something this simple...
Source Files on build 6776998357
Detailed source file information is not available for this build.