uber / tchannel-go / 1961

86%

dev: 88%

push

travis-ci

Only add connection to ch.conns if it's active

If a connection becomes active, and then closes almost immediately, then
it's possible that the close is handled before onActive is done
processing which leads to adding a inactive connection to ch.conns.

This causes the test TestTimeoutCallsThenClose to fail with state
mismatch since the number of connections has changed.

Check the connection state before adding it to the channel to avoid this
race.

4 of 4 new or added lines in 1 file covered. (100.0%)

3746 of 4331 relevant lines covered (86.49%)

10231.54 hits per line