1958
86%
dev: 88%

Ran 27 May 2016 10:53PM UTC

Jobs 4

Files 42

Run time 25min

Badge

Embed ▾

pending completion

Build # 1958

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Only add connection to ch.conns if it's active

If a connection becomes active, and then closes almost immediately, then
it's possible that the close is handled before onActive is done
processing which leads to adding a inactive connection to ch.conns.

This causes the test TestTimeoutCallsThenClose to fail with state
mismatch since the number of connections has changed.

Check the connection state before adding it to the channel to avoid this
race.

Run Details

3748 of 4331 relevant lines covered (86.54%)

10446.8 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1958.1 (TEST_TIMEOUT_SCALE=20)	27 May 2016 10:53PM UTC	42	86.19	Travis Job 1958.1
2	1958.2 (TEST_TIMEOUT_SCALE=20)	27 May 2016 10:54PM UTC	42	86.18	Travis Job 1958.2
3	1958.3 (TEST_TIMEOUT_SCALE=20)	27 May 2016 11:18PM UTC	42	85.65	Travis Job 1958.3
4	1958.4 (TEST_TIMEOUT_SCALE=20)	27 May 2016 10:54PM UTC	42	85.2	Travis Job 1958.4

Source Files on build 1958

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1958
86%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1958

uber / tchannel-go / 1958 86% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1958

uber / tchannel-go / 1958
86%
dev: 88%

README BADGES
x