skeema / skeema / 6503384479

92%

push

github

sql files: auto-ignore CREATE...SELECT and WITH SYSTEM VERSIONING

This commit improves Skeema's handling of two unsupported CREATE TABLE edge
cases in *.sql files.

1. CREATE TABLE ... SELECT statements

Skeema does not support this syntax, since it mixes DDL with DML, breaking
Skeema's workspace operation model (among other reasons). Previously,
presence of a CREATE TABLE ... SELECT statement would cause the entire
directory to be skipped with an error.

2. MariaDB system-versioned tables

These tables are labeled with a nonstandard table_type in information_schema,
causing Skeema to fail to "see" them at all on the database side. Most
commands would then harmlessly ignore these tables, however `skeema pull` in
particular was problematic: it would delete the CREATE TABLE statement from
the *.sql files, since it didn't see a corresponding table on the DB side.

Skeema may fully support one or both of these at some point in the future, but
for now we can slightly improve how these situations are treated. This commit
handles these two cases identically, as follows:

* The table will be automatically ignored by all commands, on both the
  database side and the filesystem side, much like if --ignore-table had
  matched the table name.

* The statement will otherwise be treated the same as an unparseable
  statement: `skeema diff`, `skeema push`, and `skeema format` will show a
  summary log message with the number of such statements that were skipped in
  the directory; meanwhile `skeema lint` will show an itemized list of the
  exact statements.

This means that CREATE TABLE ... SELECT no longer skips a directory with a
fatal error, and system-versioned tables no longer have their .sql definition
deleted upon `skeema pull`.

12 of 12 new or added lines in 2 files covered. (100.0%)

9489 of 10158 relevant lines covered (93.41%)

1.12 hits per line