Instagram / IGListKit / 6497384128

96%

master: 100%

push

github

Fix re-entrance + caching when using IGListCollectionViewLayout

Summary:
The issue I've been seeing is that list kit would not recalculate layout for when collection view bounds would change

IGListCollectionViewLayout has code to invalidate layout when collection view size chances however it would not happen without explicitly calling `….collectionViewLayout invalidateLayout];`

It appears that in the loop of calculating the layout we would accidentally call the code that would start caching existing layout data (not calculated at the point of call) and cache the value

This does not seem to happen all the time, however moving the cache purge to the end of layout calculation loop seems reasonable since at this point we have the new values that can't be known to the cache

As long as the consumer uses `IGListCollectionViewLayout` explicitly or implicitly through convenience initialize of `IGListCollectionView` this fix should work as is

Reviewed By: fabiomassimo

Differential Revision: D50197736

fbshipit-source-id: cb6d818f8

3 of 3 new or added lines in 1 file covered. (100.0%)

4144 of 4144 relevant lines covered (100.0%)

747.3 hits per line