ooni / probe-cli / 6344324224

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(archival): unconditionally scrub HTTP headers and bodies (#1335)

This commit modifies ArchivalMaybeBinaryData to unconditionally scrub IP
addresses and endpoints. It also renames the struct
ArchivalScrubbedMaybeBinaryData to underline that it's scrubbing now.

We're using ArchivalScrubbedMaybeBinaryData to represent HTTP headers
and bodies collected by OONI measurements.

With this commit merged, I am now much less concerned about the
potential unintended effects of aggressively using happy eyeballs, which
we started introducing as part of
https://github.com/ooni/probe/issues/2531.

In other words, the rest of the refactoring of the OONI bootstrap could
proceed a bit faster.

Run Details

19 of 19 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

24217 of 29560 relevant lines covered (81.92%)

35.35 hits per line