ooni / probe-cli / 6343909750

72%

push

github

refactor: use ArchivalMaybeBinaryString for headers list (#1334)

This commit changes the list representation of HTTP headers to use the
ArchivalMaybeBinaryString type.

Now that we have migrated most representations of HTTP headers to use
this new type, we can finally implement scrubbing.

As a reminder, we still need to migrate the ./legacy/measurex
implementation, however that one is a bit annoying because there are no
tests at all for measurex 🤦🤦🤦🤦🤦🤦🤦.

That said, given that ./legacy/measurex is deprecated and it is only
used by the tor experiment, I think leaving it untouched would probably
be the right thing to do here.

Part of https://github.com/ooni/probe/issues/2531

9 of 9 new or added lines in 1 file covered. (100.0%)

24218 of 29560 relevant lines covered (81.93%)

34.39 hits per line