ooni / probe-cli / 6313955199

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(enginenetx): make static-policy API private (#1308)

Now that we've more or less reached the point where we wanted to be with
https://github.com/ooni/probe/issues/2531, let's spend some time to
refactor the implementation, now that we know very well how it works,
such that modifying it in the future would be easier.

The first order of business here seems to hide implementation details
and get rid of too many HTTPSDialer prefixes which only cause confusion
when looking at the available structs.

Here, in particular, we deal with the static-policy API. To this end, we
also need to more some tests around because they need internals.

Also, while there, add a top-level description to some files, so that
newcomers have an idea of what each file is about.

Run Details

9 of 9 new or added lines in 2 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

23961 of 29307 relevant lines covered (81.76%)

20.61 hits per line