ooni / probe-cli / 6313671362

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(enginenetx): group by domain's endpoint (#1307)

There's no point in grouping tactics by "www.example.com" for stats
stored on disk and user-provided static policies. By grouping by domain
alone, we'll end up with mixed tactics for different ports all being
together. Which means that, code that needs to filter, needs to
explicitly filter by port. If we used "www.example.com:443" as the
group-by key, conversely, we would not need to write specialized
filtering code to only get data for the correct port. So, let's do that
and let's simplify future code that will need to get tactics known for
work for a given domain _and_ port.

Part of https://github.com/ooni/probe/issues/2531

Run Details

19 of 19 new or added lines in 3 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

23965 of 29307 relevant lines covered (81.77%)

28.73 hits per line