digidem / rpc-reflector / 6228807531

98%

push

github

fix: always return same object from client prop (#18)

* fix: Can await returned client

calling `await client` was throwing an error. The returned client should
not be thenable, and should just return the same client

* fix: always return same object from client prop

There was a bug where every time you access a client property e.g.
`client.namespace` it would return a new Proxy object, which would lead
to unexpected behaviour when accessing a client object, e.g.
`client.namespace === client.namespace` would be false. It would also
cause a lot of garbage collection slowing things down (all those Proxy
objects need to be garbage collected).

This fix caches all the sub clients that are created when you access
properties. This could be seen as a memory leak because every time you
access a client property, the value is cached, but this is effectively
lazily building the API on the server side - as long as you don't call
huge numbers of non-existent properties on the client it won't take much
more memory than the server-side API.

196 of 219 branches covered (0.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

328 of 342 relevant lines covered (95.91%)

647.58 hits per line