digidem / rpc-reflector

98%

push

github

fix: createClient.close() should reject pending and future calls (#29)

* fix: createClient.close() should reject pending and future calls

Calling `createClient.close(client)` previously only detached the message
listener. Pending RPC entries remained in the `pending` Map until each
hit its `timeout` (default 5000 ms), and subsequent calls on the same
proxy still posted a request that would also eventually time out.

This change makes `close()`:
1. Reject every entry in `pending` immediately with `Error('Channel closed')`.
2. Set a `closed` flag that the proxy `apply` trap checks first; closed
   clients reject calls synchronously without an IPC round trip.

* test: move in-flight close rejection test to e2e

Adds a `slowMethod` to the e2e fixture API and asserts that
`createClient.close(client)` rejects an in-flight request through the
real client/server round trip with `Error('Channel closed')` rather
than waiting for the per-call timeout. Removes the equivalent unit
test from `close.test.js` since the e2e variant now covers it end to
end.

254 of 267 branches covered (95.13%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

1091 of 1105 relevant lines covered (98.73%)

328.66 hits per line