ooni / probe-cli / 6079089631

84%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup(netemx): QAEnvOptionHTTPServer is now syntactic sugar (#1232)

With all the changes implemented so far, we're now well positioned to
futher cleanup netemx by implementing QAEnvOptionHTTPServer as just
syntactic sugar for QAEnvOptionNetStack.

This change allows us to delete more code that is duplicating existing
functionality and is not otherwise useful.

While there, introduce a role for a blockpage server and make sure that
such a server only listens for HTTP, thus fixing a case in which the
behavior of netemx was not consistent with the reality. After this
change, we need to skip a QA test for LTE, because LTE is actually able
to bypass the block and thus produces accurate webpage content.

Part of https://github.com/ooni/probe/issues/1803.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

Run Details

23 of 23 new or added lines in 3 files covered. (100.0%)

40 existing lines in 5 files now uncovered.

21812 of 27365 relevant lines covered (79.71%)

36.19 hits per line