ooni / probe-cli / 6078844442

72%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup(netemx): always init resolvers using QAEnvOptionNetStack (#1231)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

## Description

This diff removes code to init resolvers that does not use
QAEnvOptionNetStack. This change allows us to drop duplicate code that
we don't really need (in fact, removing this functionality does not
produce a huge diff).

While there, we introduce more resolvers IP addresses, including
8.8.8.8, so we can simplify webconnectivitylte tests.

While there, rename the uncensored root resolver as the root resolver
and use the F root resolver address for it.

While there, stop allowing to change the ISP resolver address or the
root resolver address (there's no need).

Run Details

25 of 25 new or added lines in 4 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

21896 of 27409 relevant lines covered (79.89%)

33.18 hits per line