ooni / probe-cli / 6079050236

81%

master: 84%

Build Type

Pull #1232

github

Committed by bassosimone

Commit Message

cleanup(netemx): QAEnvOptionHTTPServer is now syntactic sugar

With all the changes implemented so far, we're now well positioned
to futher cleanup netemx by implementing QAEnvOptionHTTPServer as
just syntactic sugar for QAEnvOptionNetStack.

This change allows us to delete more code that is duplicating
existing functionality and is not otherwise useful.

While there, introduce a role for a blockpage server and make sure
that such a server only listens for HTTP, thus fixing a case in which
the behavior of netemx was not consistent with the reality.

Part of https://github.com/ooni/probe/issues/1803.

Pull Request Pull Request #1232: cleanup(netemx): QAEnvOptionHTTPServer is now syntactic sugar

Run Details

23 of 23 new or added lines in 3 files covered. (100.0%)

45 existing lines in 6 files now uncovered.

21807 of 27365 relevant lines covered (79.69%)

26.17 hits per line