ooni / probe-cli / 6078459950

72%

push

github

refactor(netemx): use QAEnvOptionNetStack for ScenarioRoleDNSOverHTTPS (#1229)

This diff continues the refactoring of netemx to use a single mechanism
to create all the possible kind of servers.

While there, this diff removes the limitation that we cannot create more
than a single server per IP address, which was one of the reasons why we
started this refactoring process.

While there, make sure we have full coverage of netemx.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

25 of 25 new or added lines in 10 files covered. (100.0%)

21966 of 27484 relevant lines covered (79.92%)

36.15 hits per line