ooni / probe-cli / 6078320956

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(netemx): address issues with quic-go/quic-go (#1228)

This diff fixes https://github.com/ooni/probe/issues/2527.

The comment I originally wrote in the code to explain the issue read:

> I am wondering whether I am not fully understanding how
quic-go/quic-go works.

It turns out this comment was true. I was assuming http3.Server was
closing the listener, however, that was not the case.

I noticed this issue when reading again netemx/qaenv.go.

So, it all boiled down to PEBCAK 😬.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/2527
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

Run Details

11 of 12 new or added lines in 3 files covered. (91.67%)

7 existing lines in 2 files now uncovered.

21947 of 27481 relevant lines covered (79.86%)

25.68 hits per line